View Single Post
RedSword
SourceMod Plugin Approver
Join Date: Mar 2006
Location: Quebec, Canada
Old 05-16-2013 , 21:10   Re: [L4D & L4D2] Physics fix
Reply With Quote #12

Hi there,

if you want your plugin approved, please change the following :

You have a possible race condition with other plugins OnEntityCreated. i.e. :

plugin create timer (L193/214); 2nd plugin is executed; screw up and kill the entity; Valve entity management is done (slot is cleared); just before timer is executed, another entity is created with the timer's arg's id; then timer execute on a bad entity with the same initial ID.

To correct this behaviour, you can use EntRefToEntIndex and EntIndexToEntRef, which are the ~~equivalent of GetClientSerial-GetClientFromSerial or GetClientUserId-GetClientOfUserId for clients.

(Not needed for approval) Also, if you want to optimize your plugin, you can change your "Format" for "strcopy"; which speed up string copies. You could also add some "else" before those "if" on L209 and L211.
__________________
My plugins :
Red Maze
Afk Bomb
RAWR (per player/rounds Awp Restrict.)
Kill Assist
Be Medic

You can also Donate if you appreciate my work
RedSword is offline