[Elite_Fallen_Angel]

I would like to start off by saying that this is my first plugin with very little experience. I don't plan on getting this approved but rather get some POSITIVE criticism on the structure, style, and efficiency of the whole plugin.

The whole idea of this plugin along with some of the coding was derived from Arion's "Custom Frags and Deaths" plugin. The differences with this plugin is it is made specifically for Day of Defeat unlike Arion's Counter-Strike specific plugin. Also, with this plugin you can alter a player Score (flag caps) rather then just Kill and Deaths.

Please don't tear me apart.....

I present Dynamic KD!

Commands:

amx_alterkill <player> <desired kills>
Changes the specified players kills to the desired amount

amx_alterdeath <player> <desired deaths>
Changes the specified players deaths to the desired amount

amx_alterscore <player> <desired score>
Changes the specified players score to the desired amount


Also, Unlike Arion's plugin the alterations are immediate.

[Pro Patria Finland]

No need for fun module, you shouldn't include that.

Also, when you script, you can do

else
   dod_set_user_score (player, alteredScorez)

instead of:

    else
    {
    dod_set_user_score (player, alteredScorez)
    }

Other stuff I'll tell after further look / if I have more to tell.

Edit: And of course like this too:

    if(!is_user_connected(player))
          return PLUGIN_HANDLED

[Styles]

cool. gj

[Arkshine]

Also "Modification: ALL" . It's wrong since it's for dod only. ;)

[Elite_Fallen_Angel]

Originally Posted by Styles cool. gj

Thank you Styles.

Also, Thank you for your feedback Patria. I actually originally tried doing it that way and recieved some kind of indentation error (Something along those lines).

I will attempt to get it working that way. Is it bad that I use brackets though? I find it easier to read.


Oops, I thought I made it for DoD. My bad. Thank you for pointing that out arkshine!

[M249-M4A1]

Although not necessary, you should comment your code

[Elite_Fallen_Angel]

Yea, I wasn't sure whether to do it or not since this was a pretty simplistic code but I will do that in the future.

Thank you.

[purple_pixie]

With the "if" indentation, you can put it in braces if you want, there's no reason not to.

Some people prefer just indenting it, some people put it on the same line.

As a general rule, my theory is "if the command is just a return, don't use braces."
Anything else, I tend to, just in case I want to add more there later or w/e.

Just as long as you don't open braces on the same line as the if it's hard to go far wrong ;-)

if ( expression == true ) {
    some_code()
    } else {
    some_more_code()
}

is just the ugliest thing I have ever seen, and it's so much harder to work out what starts where.

if ( expression == true )
{
    some_code()
}
else
{
    some_more_code()
}

is infinitely better.

But so long as you don't get a compiler warning it's all idiosyncrasy / preference anyway.

Nice plugin, btw.

[Elite_Fallen_Angel]

Yea, I noticed some of the examples in the Wiki did that. It's so much easier for me with Brackets positioned the way I have them for now (As an uber beginner). Over time if I can get this down well enough I may move onto your theory.

Until such time I will just use brackets since it isn't really "hurting" the plugin.

[purple_pixie]

I'm sure I was saying you have them right already :-S

I always think a brace deserves its own line.
And they definitely deserve indentation afterwards.

if ( x )
{
    y()
}
else
{
    z()
}

is how I like to put it - undisputedly the most easily readable.

And just to be uber-pedantic ...

These are brackets: []
These are braces: {}
And these are parentheses: ()