[Chrisber]

Hi.
Currently I'm trying to send a chat text to the user (for most of you it should be easy but not for me ).
Here's my code:

void cModule::chatMsg(int iFilter, int iIndex, const char *sMessage, ...)
{
    char sBuffer[256];

    va_list vArgs;
    va_start(vArgs, sMessage);
    vsprintf(sBuffer, sMessage, vArgs);
    va_end(vArgs);

    sprintf(sBuffer, "\x03[%s] \x04%s\n", this->sPrefix, sBuffer);

    MRecipientFilter mFilter;
    mFilter.AddAllPlayers();

    bf_write *bfUserMsg = gEngine->UserMessageBegin(&mFilter, gUtils.iUserMsgChat);
    bfUserMsg->WriteByte(0);
    bfUserMsg->WriteString(sBuffer);
    bfUserMsg->WriteByte(0);
    gEngine->MessageEnd();
}

It works, the message is send to the user but with an error. You see the sprintf. I use it to add an \n and to add the module prefix to the chat message. If I do that, the output is:

[PREFIX] [PREFIX] [PREFIX] [PREFIX] [PREFIX] [PREFIX] [PREFIX] [PREFIX]

If I leave out the sprintf, the text I want to send comes and everything works well. Why does the prefix appears so often?

The type of this->sPrefx is const char*.

I hope s.o. can help me

~ Chris

[BAILOPAN]

Unrelated aside: do not use sprintf/vsprintf on arbitrary input like that. They do not check the bounds of the buffer. Use snprintf/vsnprintf instead.

[Chrisber]

Hi.
Thanks for that. I will recognize it in future

But the problem isn't solved :/

~ Chris

[Keeper]

First off, I don't like this line:

sprintf(sBuffer, "\x03[%s] \x04%s\n", this->sPrefix, sBuffer);

I would put it in another character array to be sure. Maybe test this:

void cModule::chatMsg(int iFilter, int iIndex, const char *sMessage, ...)
{
    char sBuffer[256];
    char sBuffer2[256];.

    va_list vArgs;
    va_start(vArgs, sMessage);
    vsprintf(sBuffer, sMessage, vArgs);
    va_end(vArgs);

    sprintf(sBuffer2, "\x03[%s] \x04%s\n", this->sPrefix, sBuffer);

    MRecipientFilter mFilter;
    mFilter.AddAllPlayers();

    bf_write *bfUserMsg = gEngine->UserMessageBegin(&mFilter, gUtils.iUserMsgChat);
    bfUserMsg->WriteByte(0);
    bfUserMsg->WriteString(sBuffer2);
    bfUserMsg->WriteByte(0);
    gEngine->MessageEnd();
}

Also, on a side note, if you're wanting the \x03 to work, you'll need to change the first

 bfUserMsg->WriteByte(0);

to be

bfUserMsg->WriteByte( engine->IndexOfEdict( pEntity ) )

where the pEntity is the speaker. Otherwise the colors won't work with the team.

[Chrisber]

I don't want to use chat with team color, I only want to output a normal message with gold, green and lightgreen :/

~ Chris

[PM]

Not being sure if that came through:

The prefix most likely comes so often because the output buffer pointer you pass to sprintf is the same as one of the input parameters. The standard says that behaviour in such case is undefined (analogous to overlapping memory areas passed to memcpy).

[Chrisber]

OMFG!!!
Thanks, that was the error, lol.
Thanks to all

EDIT: Why does the console puts out the following text when I'm sending the usermsg?!

SV_BroadcastMessage:  Recipient Filter for message type 23 (reliable: no, init: no) with bogus client index (X) in list of X clients

:S

~ Chris

[Chrisber]

Hi.
I found out, that the message apears X times (X = count of players in RecipientFilter).

Does anybody has an idea? :S That message spams my console :/

~ Chris

[Keeper]

The chatMsg isn't being called during a loop is it?

[Chrisber]

No.
It's called once.

~ Chris