[HamletEagle]

Not again for the bug, I'm here again asking something

It crash when getting a virtual function(tried more than one, it's not necessary about CheckWinConditions). Tried with +2(I remember it is 65, but eh), still crash.

assert_20150804093827_1.dmp[3631]: Uploading dump (out-of-process)
/tmp/dumps/assert_20150804093827_1.dmp
Segmentation fault (core dumped)

[Arkshine]

Tried, no issue. Even after several restart. Hook is well called.
Sounds like again something you did not tested properly.
Using latest dev version + official okapi version.

[HamletEagle]

You tested under linux, right ? Used 65 or 67 ?

Also tested in a friend server, it crash immediately after you restart the server. Idk what can I do wrong. What I do is:
1. Start the HLDS
2. It works correctly, hook is called, function is found.
3. Change map/do a restart
4. Server crash with the error I have posted.

Hooking a non-virtual function works fine for example.

[Arkshine]

linux, 65. I would wildly guess that your plugin or something do something unexpected. I've tested essentially with base plugin + your short plugin above modified to add the hook. Have nothing else.

If you want me to reproduce an issue, then give me a simple way to reproduce, including what I should have as plugins, amxx version, etc. Ideally having a zip of addons/ so I can test as it is.

[HamletEagle]

Ok, here is my addons folder. The test plugin is CheckWinConditionsTest.

1.Put the plugin and start the server.
2.It should work fine. Restart/change map.
3.Seg fault should occur.

[Arkshine]

What is the exact source code of the plugin?

[HamletEagle]

The one that I posted.

PHP Code:

#include <amxmodx>
#include <okapi>

public plugin_precache()
{
    new const InstallGameRulesSignature[] = {0x68,0xDEF,0xDEF,0xDEF,0xDEF,0xFF,0xDEF,0xDEF,0xDEF,0xDEF,0xDEF,0x83,0xDEF,0xDEF,0xFF,0xDEF,0xDEF,0xDEF,0xDEF,0xDEF,0xA1,0xDEF,0xDEF,0xDEF,0xDEF,0xD9,0xDEF,0xDEF,0xD8,0xDEF,0xDEF,0xDEF,0xDEF,0xDEF,0xDF}
    new const InstallGameRulesSymbol[] = "_Z16InstallGameRulesv"

    new okapi_func:InstallGameRules = okapi_build_function(OkapiGetFunctionAddress(InstallGameRulesSignature, sizeof InstallGameRulesSignature, InstallGameRulesSymbol), arg_int)
    okapi_add_hook(InstallGameRules, "OnInstallGameRules", .post = 1)
}  

public OnInstallGameRules()
{
    new Object = okapi_get_orig_return()
    new CheckWinConditionsFuncOffset = 65
    new okapi_func:CheckWinConditions = okapi_build_vfunc_ptr(Object, CheckWinConditionsFuncOffset, arg_void) 
}  

OkapiGetFunctionAddress(const FunctionSignature[] = "", SignatureLen, const FunctionSymbol[])
{
    new OkapiAddress

    if
    (
        (OkapiAddress = okapi_mod_get_symbol_ptr(FunctionSymbol)) || 
        (OkapiAddress = okapi_mod_find_sig(FunctionSignature, SignatureLen))
    )
    {
        return OkapiAddress
    }
    
    return PLUGIN_CONTINUE
} 


[Arkshine]

Your issue is with csstats.dat file.

I'm not totally sure, but you have likely corrupted data or similar, so when CSX reads this, it fucks up the memory, and as side-effect fucks up Okapi.
I've tried with CSStats editor to change one value, saving, and as result it doesn't crash. So it confirms there is something corrupted somewhere in this file.

Since not used, delete it.

[meTaLiCroSS]

Originally Posted by Arkshine Your issue is with csstats.dat file. I'm not totally sure, but you have likely corrupted data or similar, so when CSX reads this, it fucks up the memory, and as side-effect fucks up Okapi. I've tried with CSStats editor to change one value, saving, and as result it doesn't crash. So it confirms there is something corrupted somewhere in this file. Since not used, delete it.

Shhhhiieeet man, how did you discovered that easily? Wow, nice treatment with finding bugs

[Arkshine]

Well I'm not sure. it looks like Okapi fucks up memory at restart. While I could reproduce an issue under my server with HamletEagle's installation where it was crashing at map start because of this .dat file ; it did not solve the crash he has, which happens always after a restart. I was able to reproduce the behavior under a VM with an Ubuntu-based OS though. Basically I would not recommend to use Okapi for now.