[N3v3rM1nd]

Hi, I have a problem.

I have this global saved,

PHP Code:

new_g_cName[33][32] 


, it holds the names of players.

PHP Code:

public client_putinserver(iPlayer)
    get_user_name(iPlayer, g_cName[iPlayer], charsmax(g_cName[])); 


PHP Code:

public client_infochanged(id)
{
    if(!is_user_connected(id) || g_bFake[id])
        return;
    verify_name(id);
    MakeUserAdmin(id);
} 


verify_name(id) function:

PHP Code:

verify_name(id)
{
    static name[32];
    get_user_info(id, "name", name, 31);
    
    static i, ignore;
    ignore = false;
    
    for (i = 0; i <= g_sizeof_names_new; i++)
    {
        if(containi(name, g_names_new[i]) != -1)
        {
            ignore = true;
            break;
        }
    }
    
    if(ignore)
        return;
    
    for (i = 0; i < 29; i++)
        replace_all(name, 31, g_filter_chars, "");
    
    for (i = 0; i < g_sizeof_names; i++)
    {
        if(containi(name, g_names[i]) != -1 && !g_bFake[i])
        {
            formatex(name, 31, "%s [%d]", g_names_new[random_num(0, g_sizeof_names_new)], g_names_changed);
            set_user_info(id, "name", name);
            client_cmd(id, "name ^"%s^"", name);
            g_names_changed++;
        }
    }
} 


ChangeNick(iPlayer) function:

PHP Code:

public ChangeNick(iPlayer)
{
    if(!GetAccess(iPlayer, ADMIN_KICK, 3))
        return 1;
        
    new cArg[32];
    new iTarget, cNickname[32];
    read_argv(1, cArg, sizeof(cArg)-1);
    read_argv(2, cNickname, sizeof(cNickname)-1);
    iTarget = GetTarget(iPlayer, cArg, FLAG_CHECK_IMMUNITY);
    
    if(!iTarget)
        return 1;

    PrintToChat(0,"^x01[ADMIN]^x04 %s^x01: changed ^x04%s^x01's nickname to ^x03%s", g_cName[iPlayer], g_cName[iTarget], cNickname);
    set_user_info(iTarget, "name", cNickname);
    client_cmd(iTarget, "name ^"%s^"", cNickname);
    return 1;
} 


No matter what I try, g_cName[] remains the same, i.e., with the value received in client_putinserver. So, if I enter with the name ABC and change it later to ASD, it still prints ABC.

Apart from ChangeNick and verify_name, there is no other function that affects the variable.

[Bugsy]

Is the expectation that g_cName[] always has the users current name? If so, where are you setting the name to that array when the name gets changeed?

[N3v3rM1nd]

Originally Posted by Bugsy Is the expectation that g_cName[] always has the users current name? If so, where are you setting the name to that array when the name gets changeed?

Yes, g_cName[] holds the user's current name, idk how to replace the value, so i tried with copy()

PHP Code:

public ChangeNick(iPlayer)
{
    if(!GetAccess(iPlayer, ADMIN_KICK, 3))
        return 1;
        
    new cArg[32];
    new iTarget, cNickname[32];
    read_argv(1, cArg, sizeof(cArg)-1);
    read_argv(2, cNickname, sizeof(cNickname)-1);
    iTarget = GetTarget(iPlayer, cArg, FLAG_CHECK_IMMUNITY);
    
    if(!iTarget)
        return 1;

    PrintToChat(0,"^x01[ADMIN]^x04 %s^x01: changed ^x04%s^x01's nickname to ^x03%s", g_cName[iPlayer], g_cName[iTarget], cNickname);
    set_user_info(iTarget, "name", cNickname)
    client_cmd(iTarget, "name ^"%s^"", cNickname);
    copy(g_cName[iTarget], 32, cNickname) // copy the new nickname into g_cName[]
    return 1;
} 


also here

PHP Code:

verify_name(id)
{
    static name[32]
    get_user_info(id, "name", name, 31)
        
    static i, ignore
    ignore = false
        
    for (i = 0; i <= g_sizeof_names_new; i++)
    {
        if(containi(name, g_names_new[i]) != -1)
        {
            ignore = true
            break;
        }
    }
        
    if(ignore)
        return;
        
    for (i = 0; i < 29; i++)
        replace_all(name, 31, g_filter_chars, "")
        
    for (i = 0; i < g_sizeof_names; i++)
    {
        if(containi(name, g_names[i]) != -1 && !g_bFake[i])
        {
            formatex(name, 31, "%s [%d]", g_names_new[random_num(0, g_sizeof_names_new)], g_names_changed)
            set_user_info(id, "name", name)
            client_cmd(id, "name ^"%s^"", name)
            copy(g_cName[i], 32, name) // same, tried to copy the new name into g_cName[]
            g_names_changed++
        }
    }
} 


but same results

[Bugsy]

Do a test output/log in various parts of your code to see where the issue is. There’s a possibility that verify_name() is not getting called at all, your copy() line is not getting reached, or the name retrieved is still the old name.

[N3v3rM1nd]

i solved the problem, instead of client_infochanged() i used

PHP Code:

register_forward(FM_ClientUserInfoChanged, "_ClientUserInfoChanged"); 


PHP Code:

public _ClientUserInfoChanged(id)
{
    new name[32], oldname[32]
    get_user_info(id, "name", name, charsmax(name))
    get_user_name(id, oldname, charsmax(oldname))

    if(!equal(oldname, name))
        copy(g_cName[id], 32, name)
        
    verify_name(id)
        
    return 1;
} 


[fysiks]

TL;DR, is there a reason you don't just use get_user_name() when needed?

[N3v3rM1nd]

Well, storing user names globally simplifies your code by reducing redundancy, don't have to clutter your functions with repeated calls to get_user_name(), making the code cleaner and easier to understand. (I have a 12k lines of code, for me it's useful to save the names only once and not every time)

[fysiks]

It certainly doesn't simplify your code, you have to add a whole bunch of overhead to make it work. Using get_user_name() is at most two lines of code in each function that requires it. As long as you're not calling it in prethink or postthink, just using get_user_name() is so much simpler. Granted, I can't see your whole plugin or even know what it's doing so there's that but I find it hard to believe it really simplifies much.