[MyPc]

Originally Posted by Devil259 I don't have precise example, but cs_get_user_team( ) is better for CS.

Ok.
By the way why is the topic category is "Admin Commands" ?

[Devil259]

Because he doesn't modify it.

[nikhilgupta345]

Originally Posted by Napoleon_be You can optimize your code alot..

That doesn't help him at all. You should tell him what he needs to optimize.

[MyPc]

PHP Code:

if (is_user_alive(id) && cs_get_user_team(id) & CS_TEAM_CT)  
    {
        new players[32], pnum, Key;
        new szName[32], szName2[10];
    
        get_players(players, pnum, "a");
        for(new i; i < pnum; i++)
        {
            Key = players[i]
        
            if (cs_get_user_team(Key) != CS_TEAM_T)
            {
                continue;
            }
            get_user_name(Key, szName, 31);
            num_to_str(Key, szName2, 9);
            menu_additem(menu, szName, szName2, 0);
        }
        menu_display(id, menu);
        ColorChat(id, RED, "%s Only guards can use in glow menu.", TAG); // will be displayed every time the function is called
        return PLUGIN_HANDLED;
    } 


check out the commented line .

[MyPc]

Originally Posted by Devil259 if (is_user_alive(id) && cs_get_user_team(id) & CS_TEAM_CT)       {         new players[32], pnum, Key;         new szName[32], szName2[10];               get_players(players, pnum, "a");         for(new i; i < pnum; i++)         {             Key = players[i]                       if (cs_get_user_team(Key) != CS_TEAM_T)             {                 continue;             }             get_user_name(Key, szName, 31);             num_to_str(Key, szName2, 9);             menu_additem(menu, szName, szName2, 0);         }         menu_display(id, menu);         ColorChat(id, RED, "%s Only guards can use in glow menu.", TAG); // will be displayed every time the function is called         return PLUGIN_HANDLED;     } -> if (is_user_alive(id) && cs_get_user_team(id) & CS_TEAM_CT)       {         new players[32], pnum, Key;         new szName[32], szName2[10];               get_players(players, pnum, "a");         for(new i; i < pnum; i++)         {             Key = players[i]                       if (cs_get_user_team(Key) != CS_TEAM_T)             {                 ColorChat(id, RED, "%s Only guards can use in glow menu.", TAG);                 continue;             }             get_user_name(Key, szName, 31);             num_to_str(Key, szName2, 9);             menu_additem(menu, szName, szName2, 0);         }         menu_display(id, menu);         return PLUGIN_HANDLED;     }

no..
He means that if the player the writes "/glow" and he is not Counter-Terrorist this message will be displayed, your code just messages every player that isn't terrorist team player.
the right one will be :

PHP Code:

public Menu(id)
{
    new menu = menu_create("\rGlowing menu^n\yBy H0rSe(s)", "Submenu");
    if (is_user_alive(id) )
    {
        if( cs_get_user_team(id) == CS_TEAM_CT )  
        {
            new players[32], pnum, Key;
            new szName[32], szName2[10];
            
            get_players(players, pnum, "a");
            for(new i; i < pnum; i++)
            {
                Key = players[i]
                
                if (cs_get_user_team(Key) != CS_TEAM_T)
                {
                    continue;
                }
                get_user_name(Key, szName, 31);
                num_to_str(Key, szName2, 9);
                menu_additem(menu, szName, szName2, 0);
            }
            menu_display(id, menu);
            return PLUGIN_HANDLED;
        }
        else
        {
            ColorChat(id, RED, "%s Only guards can use in glow menu.", TAG);
            return PLUGIN_HANDLED;
        }
    }
    else
    {
        ColorChat(id, RED, "%s Only alive player can use the glow menu.", TAG);
        return PLUGIN_HANDLED;
    }
    return PLUGIN_HANDLED
} 


[Devil259]

nvm, i didn't understand..

[Napoleon_be]

Originally Posted by nikhilgupta345 That doesn't help him at all. You should tell him what he needs to optimize.

He could use const's for color codes, color names and use formatex to use the menu. Example from my plugin:

PHP Code:

new const g_szGlowMenuColors[][33] = 
{
    "Red",
    "Green",
    "Blue",
    "Yellow",
    "Orange",
    "Purple",
    "White",
    "Pink",
    "Light Blue",
    "Light Green",
    "Remove Glow"
}

new const g_szGlowMenuColorCodes[][3] =
{
    {255, 0, 0},
    {0, 255, 0},
    {0, 0, 255},
    {255, 255, 0},
    {255, 165, 0},
    {128, 0, 128},
    {255, 255, 255},
    {255, 192, 203},
    {173, 216, 230},
    {193, 255, 193},
    {0, 0, 0}
} 


Formatex:

PHP Code:

new menu = menu_create("\yGlow\r Menu\d |\r Advanced\y Colors\w!", "menu_handler")

    new szTemp[500], Key[6]

    for(new i = 0; i < sizeof(g_szGlowMenuColors); i++)
    {
        formatex(szTemp, charsmax(szTemp), "\y%s", g_szGlowMenuColors[i])
        num_to_str(i, Key, charsmax(Key))
        menu_additem(menu, szTemp, Key)
    }

    menu_display(id, menu) 


Handler:

PHP Code:

public menu_handler(id, menu, item)
{
    if(item == MENU_EXIT || !is_user_alive(id))
    {
        menu_destroy(menu)
        return PLUGIN_HANDLED
    }

    get_user_name(id, szName, charsmax(szName))
    ColorChat(0, GREEN, "%s^x03 %s^x01 has choosen the glow color:^x04 %s", get_pcvar_string(p_cvarszPrefix, szTag, charsmax(szTag)), szName, g_szGlowMenuColors[item])
    set_user_rendering(id, kRenderFxGlowShell, g_szGlowMenuColorCodes[item][0], g_szGlowMenuColorCodes[item][1], g_szGlowMenuColorCodes[item][2], kRenderNormal, 25)
    menu_destroy(menu)

    return PLUGIN_CONTINUE
} 


This is just an optimization for your code.
More colors should be useful

[drekes]

Or he could do this:
http://forums.alliedmods.net/showpos...93&postcount=5

[H0rSe]

I am do more stuff in the plugin, just for now, IS OK ?

[MyPc]

Originally Posted by H0rSe I am do more stuff in the plugin, just for now, IS OK ?

no, checkout the comments.

Originally Posted by Napoleon_be He could use const's for color codes, color names and use formatex to use the menu. Example from my plugin: PHP Code: new const g_szGlowMenuColors[][33] =  {     "Red",     "Green",     "Blue",     "Yellow",     "Orange",     "Purple",     "White",     "Pink",     "Light Blue",     "Light Green",     "Remove Glow" } new const g_szGlowMenuColorCodes[][3] = {     {255, 0, 0},     {0, 255, 0},     {0, 0, 255},     {255, 255, 0},     {255, 165, 0},     {128, 0, 128},     {255, 255, 255},     {255, 192, 203},     {173, 216, 230},     {193, 255, 193},     {0, 0, 0} }  Formatex: PHP Code: new menu = menu_create("\yGlow\r Menu\d |\r Advanced\y Colors\w!", "menu_handler")     new szTemp[500], Key[6]     for(new i = 0; i < sizeof(g_szGlowMenuColors); i++)     {         formatex(szTemp, charsmax(szTemp), "\y%s", g_szGlowMenuColors[i])         num_to_str(i, Key, charsmax(Key))         menu_additem(menu, szTemp, Key)     }     menu_display(id, menu)  Handler: PHP Code: public menu_handler(id, menu, item) {     if(item == MENU_EXIT || !is_user_alive(id))     {         menu_destroy(menu)         return PLUGIN_HANDLED     }     get_user_name(id, szName, charsmax(szName))     ColorChat(0, GREEN, "%s^x03 %s^x01 has choosen the glow color:^x04 %s", get_pcvar_string(p_cvarszPrefix, szTag, charsmax(szTag)), szName, g_szGlowMenuColors[item])     set_user_rendering(id, kRenderFxGlowShell, g_szGlowMenuColorCodes[item][0], g_szGlowMenuColorCodes[item][1], g_szGlowMenuColorCodes[item][2], kRenderNormal, 25)     menu_destroy(menu)     return PLUGIN_CONTINUE }  This is just an optimization for your code. More colors should be useful

your vector for "Remove Glow" is { 0, 0, 0 } which will make the player invisible, you should reset the user rendering and not make him invisible.

i optimized the colors menu part just combine it with your code

new g_szColors[ ] [ ] =
{
    "Red", 
    "Green", 
    "Blue", 
    "Yellow", 
    "Orange", 
    "Purple", 
    "White", 
    "Pink", 
    "Light Blue", 
    "Light Green"
}

new g_szVecColors[ ] [ 3 ] =
{
    {255, 0, 0}, 
    {0, 255, 0}, 
    {0, 0, 255}, 
    {255, 255, 0}, 
    {255, 165, 0}, 
    {128, 0, 128}, 
    {255, 255, 255}, 
    {255, 192, 203}, 
    {173, 216, 230}, 
    {193, 255, 193}
}

public fnGlowMenu( iIndex )
{
    new iMenu = menu_create( "Menu name", "glow_menu_handler" ), num[ 10 ], last_item[ 128 ];
    
    for( new i = 1; i < sizeof g_szColors + 1; i++ )
    {
        num_to_str( i, num, sizeof num - 1 );
        menu_additem( iMenu, g_szColors[ i - 1 ], num );
    }
    formatex( last_item, sizeof last_item - 1, "%d", sizeof g_szColors + 1 );
    menu_additem( iMenu, "Remove Glow", last_item );
    
    menu_setprop( iMenu, MPROP_EXIT, MEXIT_ALL );
    
    menu_display( iIndex, iMenu, 0 );
}

public glow_menu_handler( iIndex, iMenu, iItem )
{
    if( iItem == MENU_EXIT )
    {
        menu_destroy( iMenu );
        return PLUGIN_HANDLED;
    }
    
    new iData[ 64 ], iName[ 64 ], iAccess, iCallBack;
    menu_item_getinfo( iMenu, iItem, iAccess, iData, sizeof iData - 1, iName, sizeof iName - 1, iCallBack );
    
    new iKey = str_to_num( iData );
    
    if( iKey == sizeof g_szColors + 1 )
    {
        set_user_rendering( iIndex );
    }
    else
    {
        set_user_rendering( iIndex, kRenderFxGlowShell, g_szVecColors[ iKey - 1 ] [ 0 ], g_szVecColors[ iKey - 1 ] [ 1 ], g_szVecColors[ iKey - 1 ] [ 2 ], kRenderNormal, 200 )
    }
    menu_destroy( iMenu );
    return PLUGIN_HANDLED;
}

Test this code cause i didn't test it i got to go.