[fysiks]

Originally Posted by Mucx Meanwhile i discovered this, but i have no clue what version is better. PHP Code: stock GetPlayersNum( CsTeams:iTeam ) {     new iNum;     for( new i = 1; i <= get_maxplayers( ); i++ ) {         if( is_user_connected( i ) && cs_get_user_team( i ) == iTeam )             iNum++;     }     return iNum; }

I would use this one for simplicity. The difference will likely be negligible to your server. However, there is one optimization that is needed:

PHP Code:

stock GetPlayersNum( CsTeams:iTeam )
{
    new iNum, iMaxPlayers = get_maxplayers();
    for( new i = 1; i <= iMaxPlayers; i++ )
    {
        if( is_user_connected( i ) && cs_get_user_team( i ) == iTeam )
            iNum++;
    }
    return iNum;
} 


There is a way to optimize a little more but this should be fine.

[makavelli]

oh ok,
sry if my questions are annoying but its the only way i will really learn this stuff;
Got a few more questions:

PHP Code:

stock GetPlayersNum( CsTeams:iTeam ) 
{ 
    new iNum, iMaxPlayers = get_maxplayers(); //what does this i stand for in this script is it just a string to store the playernumbers in?
     for( new i = 1; i <= iMaxPlayers; i++ ) //what does this outcome mean; i++?
    { 
        if( is_user_connected( i ) && cs_get_user_team( i ) == iTeam ) 
            iNum++; // and what are the meanings of the ( i )'s in this line? and the inum++?
    } 
    return iNum; 
} 


[drekes]

The i is a variable that holds the count of the loop.
The loop starts at 1, and increments i by 1 every time it loops.

PHP Code:

for(new i = 1: i < iMaxPlayers; i++)
{
    // If player with index i is connected & in the right team
    if(is_user_connected(i) && cs_get_user_team(i) == iTeam)
        // Increment the player count var by 1
        iNum++

    // i get increments by 1.
} 


So if for example iMaxPlayers is 4, the loop does this:

PHP Code:

i = 1. if player 1 is connected & in the right team, iNum (which is 0 here) + 1.
i = 2. if player 2 is connected & in the right team, iNum (which is 1 here) + 1.
i = 3. if player 3 is not connected or not in the right team, do nothing.
i = 4. if player 4 is connected & in the right team, iNum (which is 2 here) + 1. 


So iNum now holds 3, the amount of players connected & in the right team.

[makavelli]

Originally Posted by drekes PHP Code: for(new i = 1: i < iMaxPlayers; i++)//--> but I cant find his condition for his iMaxPlayers or is that always the server's player slots? and why must there be an i before MaxPlayers? {     // If player with index i is connected & in the right team //1--> what do you mean by player with index i, what is index i with that player? //1--->  lets say that he is player 1 that connects is i this then for him: //1----> i = 1. if player 1 is connected & in the right team, iNum (which is 0 here) + 1. //2-> the right team is Ter, does he have to repeat this code block again then for the ct and spec team?     if(is_user_connected(i) && cs_get_user_team(i) == iTeam)         // Increment the player count var by 1 //3-> && cs_get_user_team(i) == iTeam (this means: check if player is on ter team right? or: & in the right team ==(that equals) Ter.?       iNum++     // i get increments by 1. }  So if for example iMaxPlayers is 4, the loop does this: PHP Code: i = 1. if player 1 is connected & in the right team, iNum (which is 0 here) + 1. i = 2. if player 2 is connected & in the right team, iNum (which is 1 here) + 1. i = 3. if player 3 is not connected or not in the right team, do nothing. i = 4. if player 4 is connected & in the right team, iNum (which is 2 here) + 1.  So iNum now holds 3, the amount of players connected & in the right team.

[fysiks]

The "i" in iMaxPlayers is just part of the name. It doesn't change anything. It is just a method of reminding the people who read the code that the variable is an integer.

[makavelli]

Originally Posted by fysiks The "i" in iMaxPlayers is just part of the name. It doesn't change anything. It is just a method of reminding the people who read the code that the variable is an integer.

oh ok does that count for everything starting with i.... in his script?

[fysiks]

Originally Posted by makavelli oh ok does that count for everything starting with i.... in his script?

It really depends on who is the author of the code because some people don't understand what it means and just put an "i" in front of all their variables.

In the case of this code (iNum, iMaxPlayers) they are being used as integers.