[Bugsy]

I think what you (or exolent) are missing in that code is the socket_change() check before accepting a connection. You are constantly trying to accept a connection when there is not one there waiting to be accepted.

If you use AMX-X Studio, use the built-in socket terminal (Tools -> Socket Terminal) to play with this along with the server console.

PHP Code:

#include <amxmodx>
#include <sockets_hz>

new const VERSION[] = "0.1";

const SERVER_SOCKETS = 50;

const TASK_LISTEN = 4345;
const TASK_SERVER = 4346;

new g_Server[ SERVER_SOCKETS ];
new g_ListenSocket;

public plugin_init() 
{
    register_plugin( "Sockets server demo" , VERSION , "bugsy" );
    
    register_concmd( "test" , "Test" );
    register_concmd( "broadcast" , "SayMsg" );
}

public plugin_end()
{
    socket_close( g_ListenSocket );
    
    for ( new i = 0 ; i < SERVER_SOCKETS ; i++ )
    {
        if ( g_Server[ i ] )
        {
            socket_close( g_Server[ i ] );
        }
    }
}

public Test()
{
    new iError;
    
    if ( ( g_ListenSocket = socket_listen( "127.0.0.1" , 2323 , SOCKET_TCP , iError ) ) > 0 )
    {
        socket_unblock( g_ListenSocket );
        
        set_task( 0.25 , "Listen" , .id=TASK_LISTEN , .flags="b" );
        set_task( 0.25 , "Server" , .id=TASK_SERVER , .flags="b" );
        
        server_print( "Now listening for connections..." );
    }
}

public Listen()
{
    if ( socket_change( g_ListenSocket ) )
    {
        server_print( "Connection requested" );
        
        new iSocket = GetOpenSocket();
        
        if ( iSocket == -1 )
        {
            server_print( "Declined connection request, all server sockets are full!" );
        }
        else
        {
            if ( ( g_Server[ iSocket ] = socket_accept( g_ListenSocket ) ) > 0 )
            {
                server_print( "Connection request successfully accepted!" );
                
                for ( new i = 0 ; i < SERVER_SOCKETS ; i++ )
                {
                    if ( g_Server[ i ] )
                    {
                        socket_send( g_Server[ i ] , "New connection to the server!" , 30 );
                    }
                }
            }
        }
    }
}

public Server()
{
    static szRecv[ 128 ];
    
    for ( new iCheck = 0 ; iCheck < SERVER_SOCKETS ; iCheck++ )
    {
        if ( g_Server[ iCheck ] && socket_change( g_Server[ iCheck ] ) )
        {
            if ( socket_recv( g_Server[ iCheck ] , szRecv , charsmax( szRecv ) ) )
            {
                server_print( "[%d] %s" , iCheck , szRecv );
                
                for ( new i = 0 ; i < SERVER_SOCKETS ; i++ )
                {
                    if ( g_Server[ i ] )
                    {
                        socket_send( g_Server[ i ] , szRecv , charsmax( szRecv ) );
                    }
                }
            }
            else
            {
                server_print( "[%d] disconnected!" , iCheck );
                socket_close( g_Server[ iCheck ] );
                g_Server[ iCheck ] = 0;
            }
        }
    }
}

GetOpenSocket()
{
    new iFound = -1;
    
    for ( new i = 0 ; i < SERVER_SOCKETS ; i++ )
    {
        if ( g_Server[ i ] == 0 )
        {
            iFound = i;
            break;
        }
    }
    
    return iFound;
}

public SayMsg()
{
    for ( new i = 0 ; i < SERVER_SOCKETS ; i++ )
    {
        if ( g_Server[ i ] )
        {
            socket_send( g_Server[ i ] , "[SERVER] Hello clients!" , 24 );
        }
    }
} 


[Guxi]

Originally Posted by Bugsy I think what you (or exolent) are missing in that code is the socket_change() check before accepting a connection. You are constantly trying to accept a connection when there is not one there waiting to be accepted. If you use AMX-X Studio, use the built-in socket terminal (Tools -> Socket Terminal) to play with this along with the server console. PHP Code: #include <amxmodx> #include <sockets_hz> new const VERSION[] = "0.1"; const SERVER_SOCKETS = 50; const TASK_LISTEN = 4345; const TASK_SERVER = 4346; new g_Server[ SERVER_SOCKETS ]; new g_ListenSocket; public plugin_init()  {     register_plugin( "Sockets server demo" , VERSION , "bugsy" );          register_concmd( "test" , "Test" );     register_concmd( "broadcast" , "SayMsg" ); } public plugin_end() {     socket_close( g_ListenSocket );          for ( new i = 0 ; i < SERVER_SOCKETS ; i++ )     {         if ( g_Server[ i ] )         {             socket_close( g_Server[ i ] );         }     } } public Test() {     new iError;          if ( ( g_ListenSocket = socket_listen( "127.0.0.1" , 2323 , SOCKET_TCP , iError ) ) > 0 )     {         socket_unblock( g_ListenSocket );                  set_task( 0.25 , "Listen" , .id=TASK_LISTEN , .flags="b" );         set_task( 0.25 , "Server" , .id=TASK_SERVER , .flags="b" );                  server_print( "Now listening for connections..." );     } } public Listen() {     if ( socket_change( g_ListenSocket ) )     {         server_print( "Connection requested" );                  new iSocket = GetOpenSocket();                  if ( iSocket == -1 )         {             server_print( "Declined connection request, all server sockets are full!" );         }         else         {             if ( ( g_Server[ iSocket ] = socket_accept( g_ListenSocket ) ) > 0 )             {                 server_print( "Connection request successfully accepted!" );                                  for ( new i = 0 ; i < SERVER_SOCKETS ; i++ )                 {                     if ( g_Server[ i ] )                     {                         socket_send( g_Server[ i ] , "New connection to the server!" , 30 );                     }                 }             }         }     } } public Server() {     static szRecv[ 128 ];          for ( new iCheck = 0 ; iCheck < SERVER_SOCKETS ; iCheck++ )     {         if ( g_Server[ iCheck ] && socket_change( g_Server[ iCheck ] ) )         {             if ( socket_recv( g_Server[ iCheck ] , szRecv , charsmax( szRecv ) ) )             {                 server_print( "[%d] %s" , iCheck , szRecv );                                  for ( new i = 0 ; i < SERVER_SOCKETS ; i++ )                 {                     if ( g_Server[ i ] )                     {                         socket_send( g_Server[ i ] , szRecv , charsmax( szRecv ) );                     }                 }             }             else             {                 server_print( "[%d] disconnected!" , iCheck );                 socket_close( g_Server[ iCheck ] );                 g_Server[ iCheck ] = 0;             }         }     } } GetOpenSocket() {     new iFound = -1;          for ( new i = 0 ; i < SERVER_SOCKETS ; i++ )     {         if ( g_Server[ i ] == 0 )         {             iFound = i;             break;         }     }          return iFound; } public SayMsg() {     for ( new i = 0 ; i < SERVER_SOCKETS ; i++ )     {         if ( g_Server[ i ] )         {             socket_send( g_Server[ i ] , "[SERVER] Hello clients!" , 24 );         }     } }

I've sent "rcon test" to the console.
Then i tried to sent send a tcp packet from and it establishes connection like before but i dont get any message on the server as it was supposed to appear.

This never gets activated, same like any other server_print command except for "Now listening for connections".

PHP Code:

public Listen()
{
    if ( socket_change( g_ListenSocket ) )
    {
        server_print( "Connection requested" );
    ... 
  } 


Am i missing to do something or?
Thanks.

[Bugsy]

Im not sure but it works for me.

Do 'test' command which starts the listen server, then connect to the server with a client. I can take screen shots of it working if you want. You must be doing something wrong.

[Guxi]

Originally Posted by Bugsy Im not sure but it works for me. Do 'test' command which starts the listen server, then connect to the server with a client. I can take screen shots of it working if you want. You must be doing something wrong.

What client are you using to connect?
I'd like to see some screenshot's if i may.

[Bugsy]

As said above, using the console built into AMX-X studio along with hlds

[Guxi]

Originally Posted by Bugsy As said above, using the console built into AMX-X studio along with hlds

I was using 2 different clients. Socket terminal from the AMX-X studio & another 'packet sender' program.
I've successfully called a function by "rcon test", but nothing else was printed.

[Bugsy]

The sockets console in AMX-X studio is a little weird..

Once a client connects, server sends "New connection to the server!", which didn't appear until I said from the console "Hello server". From server console I then did "broadcast" command, which sends "[SERVER] Hello clients!", but that did not appear until I sent ".." from sockets console. Not really relevant to your issue, but just so you have an idea of whats going in in my screen shot.