[Zephyrus]

Originally Posted by psychonic This should remove the 32 cap, assuming that you've added more spawns to get past the 30 cap. I haven't fully tested as I don't have time at the moment to mess around with spawns. If it works, I'll compile for linux later. It's a VSP so you'll need to add a vdf in the addons dir, similar to metamod's.

ive only disassembled it but as far as i remember i tried your method and it wont work

[psychonic]

Originally Posted by Zephyrus ive only disassembled it

You could have just asked. I'm not going to hide information like you are.

I just hooked IServerGameClients::GetPlayerLimits. Debugging with a watch on the max clients showed that it was changing in CGameServer::InitMaxClients twice, one of the times presumably after the GetPlayerLimits call.

This makes sense as while GPL says that the max is 64, is has the default as 32, and the default gets used due to -maxplayers no longer being read. If this isn't the only place it's getting reset, I'll just debug it further. The only other place I foresee it getting reset is in ReplyReservationRequest when it sets it to the numSlots told to it by the lobby, after which it can just be reverted.

[Zephyrus]

Originally Posted by psychonic You could have just asked. I'm not going to hide information like you are. I just hooked IServerGameClients::GetPlayerLimits. Debugging with a watch on the max clients showed that it was changing in CGameServer::InitMaxClients twice, one of the times presumably after the GetPlayerLimits call. This makes sense as while GPL says that the max is 64, is has the default as 32, and the default gets used due to -maxplayers no longer being read. If this isn't the only place it's getting reset, I'll just debug it further. The only other place I foresee it getting reset is in ReplyReservationRequest when it sets it to the numSlots told to it by the lobby, after which it can just be reverted.

there are quite a few coders ive told about how i did it, one of them was databomb, and btw you wanna use SetMaxClients instead of InitMaxClients

[psychonic]

Originally Posted by Zephyrus there are quite a few coders ive told about how i did it, one of them was databomb, and btw you wanna use SetMaxClients instead of InitMaxClients

I realize that just calling SetMaxClients with a higher number sometime after start will probably work, but I would rather identify why that is being called with 32 to block it at the source or have a deterministic place to set it back.

[Zephyrus]

Originally Posted by psychonic I realize that just calling SetMaxClients with a higher number sometime after start will probably work, but I would rather identify why that is being called with 32 and have a deterministic place to set it back.

i didnt mess with it because by the time your hook gets called (if it gets called at all?) its already too late, if you check the srcds output its like the second or third line that says "maxplayers set to 32"

[asherkin]

Originally Posted by Zephyrus i didnt mess with it because by the time your hook gets called (if it gets called at all?) its already too late, if you check the srcds output its like the second or third line that says "maxplayers set to 32"

Hence why it's a VSP not a MM:S plugin nor SM extension.

[psychonic]

Originally Posted by Zephyrus i didnt mess with it because by the time your hook gets called (if it gets called at all?) its already too late, if you check the srcds output its like the second or third line that says "maxplayers set to 32"

I disagree.

The function certainly gets called and does so before the printed "maxplayers set to 32".


Breakpoint 3, CGameServer::InitMaxClients (this=<value optimized out>)
at /home/buildbot/buildslave_hpath/csgo_pcbeta_linux/build/src/engine/./sv_main.cpp:776
776 /home/buildbot/buildslave_hpath/csgo_pcbeta_linux/build/src/engine/./sv_main.cpp: No such file or directory.
in /home/buildbot/buildslave_hpath/csgo_pcbeta_linux/build/src/engine/./sv_main.cpp
(gdb) c
Continuing.

Breakpoint 5, CServerGameClients::GetPlayerLimits (this=0xb3842d38, minplayers=@0xbfffd1fc, maxplayers=@0xbfffd1f8, defaultMaxPlayers=@0xbfffd1f4)
at /home/buildbot/buildslave_hpath/csgo_pcbeta_linux/build/src/game/server/./cstrike15/cs_gameinterface.cpp:28
28 /home/buildbot/buildslave_hpath/csgo_pcbeta_linux/build/src/game/server/./cstrike15/cs_gameinterface.cpp: No such file or directory.
in /home/buildbot/buildslave_hpath/csgo_pcbeta_linux/build/src/game/server/./cstrike15/cs_gameinterface.cpp
(gdb) c
Continuing.
Hardware watchpoint 1: sv.m_nMaxClientsLimit

Old value = 0
New value = 64
CGameServer::InitMaxClients (this=<value optimized out>) at /home/buildbot/buildslave_hpath/csgo_pcbeta_linux/build/src/engine/./sv_main.cpp:818
818 /home/buildbot/buildslave_hpath/csgo_pcbeta_linux/build/src/engine/./sv_main.cpp: No such file or directory.
in /home/buildbot/buildslave_hpath/csgo_pcbeta_linux/build/src/engine/./sv_main.cpp
(gdb) c
Continuing.
Hardware watchpoint 2: sv.m_nMaxclients

Old value = 0
New value = 32
CGameServer::SetMaxClients (this=<value optimized out>) at /home/buildbot/buildslave_hpath/csgo_pcbeta_linux/build/src/engine/./sv_main.cpp:2031
2031 in /home/buildbot/buildslave_hpath/csgo_pcbeta_linux/build/src/engine/./sv_main.cpp
(gdb) c
Continuing.
maxplayers set to 32


This also supports what I said, that InitMaxClients initialized the max to 64 and then calls SetMaxClients with 32 to set the current max, after calling GetPlayerLimits, still within InitMaxClients.

[SilentBr]

Originally Posted by psychonic This should remove the 32 cap, assuming that you've added more spawns to get past the 30 cap. I haven't fully tested as I don't have time at the moment to mess around with spawns. If it works, I'll compile for linux later. It's a VSP so you'll need to add a vdf in the addons dir, similar to metamod's.

I would love test it right now but it seems only for windows? Please do a Linux version and I test it as soon as you post.

[psychonic]

Originally Posted by SilentBr I would love test it right now but it seems only for windows? Please do a Linux version and I test it as soon as you post.

I said in my post that I will compile it for linux later. You don't need to ask for it both in a both and PM simultaneously.

[SilentBr]

Originally Posted by psychonic I said in my post that I will compile it for linux later. You don't need to ask for it both in a both and PM simultaneously.

Sorry I didnt see the part that you said you was going to compile for Linux. I did send you a PM because maybe you got a forum email... Sorry again

Anyway, you dont have to wait to check if windows is woking. When you have free time please compile for linux and I will test.

I cant wait to test it in my server.

Thanks!