[Exolent[jNr]]

Originally Posted by r0ck Hunter-Digital thanks but one more request sometimes get_players doesnt works resulting to restart the server map restart also fails and i have searched a lot and they also say that get_players has bugs so can you do something and change get_players to something else ? Thanks

The problem is not with get_players(). Show your full code.

[r0ck]

Originally Posted by Exolent[jNr] The problem is not with get_players(). Show your full code.

its with get_players because i have tried that code separately because i also thought that its problem with my full code but fail, get_players when Match with passed team shows bugs sometimes (very less but had to restart server )

final code :-

PHP Code:

public team_up(id) 
{

    if (cs_get_user_team(id) == CS_TEAM_CT && is_user_alive(id))
    {
        new szName[32]
        get_user_name(id, szName, charsmax(szName))
        
        new playerCount
        new Players[32] 
            
        get_players(Players, playerCount, "ae", "TERRORIST") 
        
        new iExtraPlayers = playerCount % 2
        
        if (iExtraPlayers) 
        {
            ColorChat(id, RED, "%s Cannot Divide^x04 the Team^x01 due to odd number of^x03 Terrorists", PREFIX)
        }
        else if(g_teamdivide == true)
        {
            ColorChat(id, RED, "%s Team has already been^x04 Divided", PREFIX)
        }
        else
        {
            for(new maxPerSquad = (playerCount / 2), squads[2], squad, player, i = 0; i < playerCount; i++)
            {
                player = Players[i]
                squad = random_num(0, 1)

                if(squads[squad] >= maxPerSquad)
                    squad = !squad
                else
                    squads[squad]++

                entity_set_int(player, EV_INT_skin, squad + 5)
                color_view(player) 
                                
            }
            ColorChat(0, RED, "%s^x04 %s^x01 has Divided^x03 Prisoners^x01 into two Teams", PREFIX, szName)
            g_teamdivide = true
        }
    }
} 


[r0ck]

http://www.amxmodx.org/funcwiki.php?go=func&id=174

read last lines

Note: "e" flag can return incorrect results (for cstrike/czero at least) when not used with the "a" flag. This is because when players change team, get_players() and get_user_team() will return their old team until they spawn again. "We don't really support get_players() with flags anymore. It was a bad idea and if it was our choice, it would have never been added to the original AMX Mod." - BAILOPAN

Though its written ae doesnt bugs but it does i have search and many have written that it does bug so ...

[nikhilgupta345]

I have never had problems with get_players, using flags or not. I never use "e" on its own, only "ae", and it works fine.

If you are getting bugs with ae, it's probably something wrong with your code.

[Hunter-Digital]

If you say you have problems with get_players() just do a for() loop and check team, that'll surely work.

I for one never used get_players() just because of that note quoted above, I like to know that my code will work

[Exolent[jNr]]

I swear I've said this at least 10 times.

When a player switches teams while alive, the player's team index (team = get_user_team()) is not updated until next spawn (or maybe next round).
However, the player's team name (get_user_team(.., team_name, charsmax(team_name))) is automatically updated when switching teams.
get_players() checks by team index rather than team name, so it can only give false results when getting players that include dead players and you are checking team-specific players.
If you plan on getting players that way (including dead for team-specific) then it would be better to get dead players and check cs_get_user_team() in the loop.

I wish people would stop spreading "get_players() doesn't work/is bugged/no longer supported" when it still works perfectly fine except for this one situation, or at least tell what I said when they say it is bugged sometimes.
In the way get_players() is used in this thread, there is no bug from the function.
Therefore, it is your code that has issues, not that function.

[r0ck]

let me tell you the bug ..

get_players works fine most of the time but when it starts showing bug , it never stops till i restart the server (map restart also doesnt works)

bug :- when i say the command team_up whether there are odd or even number of terrorists it always executes he last line which is :- and nothing happens it always shows this then till restarting server and as i told earlier that i have tried this little part separately to check whether my full code has bugs and this part is only bugged

ColorChat(0, RED, "%s^x04 %s^x01 has Divided^x03 Prisoners^x01 into two Teams", PREFIX, szName) g_teamdivide = true

[nikhilgupta345]

Originally Posted by Exolent[jNr] I swear I've said this at least 10 times. When a player switches teams while alive, the player's team index (team = get_user_team()) is not updated until next spawn (or maybe next round). However, the player's team name (get_user_team(.., team_name, charsmax(team_name))) is automatically updated when switching teams. get_players() checks by team index rather than team name, so it can only give false results when getting players that include dead players and you are checking team-specific players. If you plan on getting players that way (including dead for team-specific) then it would be better to get dead players and check cs_get_user_team() in the loop. I wish people would stop spreading "get_players() doesn't work/is bugged/no longer supported" when it still works perfectly fine except for this one situation, or at least tell what I said when they say it is bugged sometimes. In the way get_players() is used in this thread, there is no bug from the function. Therefore, it is your code that has issues, not that function.

Has anybody pushed a bug fix for get_players to check by team-name rather than team-index?

[Hunter-Digital]

You should check for "g_teamdivide" before everything else in that function.

And I don't really understand what you're saying... for starters, learn to use commas.

[fysiks]

Originally Posted by nikhilgupta345 Has anybody pushed a bug fix for get_players to check by team-name rather than team-index?

Arkshine submitted the diff fo fix it. Afaik, it just needs pushed into the dev version.

https://bugs.alliedmods.net/show_bug.cgi?id=4656