[Nomarky]

Thats what I was getting at, not sorting the list by permissions

[DontWannaName]

Crashes my servers with admin list set to 2 and helpmenu installed which has the same feature but not by !admins. No errors just a minidump.

[xomp]

!admins crashes the server, plenty of dump files :S I've D-D-D-Deleted this Plugin..

[Atreus]

I'd install this if not for the errors reported above. Is this working, or broken?

[willy1234x1]

Originally Posted by Atreus I'd install this if not for the errors reported above. Is this working, or broken?

No it's not working, I used to use it on the HS servers but we soon found the crashing server issue and didn't really like giving our players the power to instacrash it.

[Sillium]

Maybe someone could provide a trace so the developer can take a look at it?

[Antithasys]

If you close the handle on MenuAction_Cancel or MenuAction_Select it will crash the server every time someone hits anything other than the exit number.

You only need to deal with a MenuAction_Cancel if you want to display a previous menu, like topmenu, or MenuAction_Select if you actually care if they select something. Every time the menu is done MenuAction_End is called. If you closehandle before it can call it and while the menu is technically still active, it will crash.

Fix:

PHP Code:

public MenuListHandler(Handle:menu, MenuAction:action, param1, param2)
{
     if (action == MenuAction_End)
          CloseHandle(menu);
} 


You should also consider changing from hooking the say commands to your own console command with RegConsoleCmd. There is no reason to hook everything said when all you want is the command trigger. In addition, if you create cvars, you should run the AutoExecConfig command.

EDIT:

I went ahead and changed the code to reflect these changes. I also added a requested item for a cvar to display admins with a certain flag. Only 1 flag can be mentioned here, even thou it is in char format. It will always check for root so "z" is never needed. Config file will be made when first ran.

Fredd:

I know I did not have permission to alter your code so I will be more then happy to remove this attachment if you like

[Atreus]

Oh, awesome. I'm currently working on some other stuff on our server, but hopefully someone else will be nice enough to see if all crashes are fixed on this now ;)

[Antithasys]

Originally Posted by Atreus Oh, awesome. I'm currently working on some other stuff on our server, but hopefully someone else will be nice enough to see if all crashes are fixed on this now ;)

I am tested it and it works just fine.

[zhelev81]

yes now it works ,tnx for fixing it,it was crashing the server when u try to see the admins omg u type !admins and the server shuted down It was like u're not allowed to look at the adimn list