[Splat.MothaFuckA]

Pimpslap Beta 1.0

Author:
LoGiTeCh AKA Splat.MothaFuckA

Release Version:
Beta 1.0

Features:
Pimpslapping.

Description Of Plugin:
This plugin basically is modifying amx_slap to amx_pimpslap.
The plugin was made for entertainment, when you type amx_pimpslap <name> (pimpslaps desired player) It will pimpslap the player repeatedly 99 times (or untill the desire player reaches the HP of 1.)
When he is in the air with 1 HP, it will activate No Fall Damage so he will not die when he hits the ground.

Enter this in the bottom of plugins.ini:

"pimpslap.amxx" without the ""

Admin Commands:

• amx_pimpslap <name> Pimpslap's the desired player.

Credits:

LoGiTeCh AKA Splat.MothaFuckA

Note: This is my first plugin so if you see any bugs or errors report them to me via PM or post below. Please criticize or give comments because this is my first plugin, and want to improve. Thank you!

[wrecked_]

Don't attatch the .amxx file.

EDIT:
1) Fix your indentation, tabs > 4 spaces.
2) Undefine PLUGIN, VERSION, and AUTHOR if you are going to personally fill in the parameters for register_plugin.
3) Edit the whitespace, some is efficient and readable, your is pretty strangely done. ( Just a suggestion, #3 )

[Splat.MothaFuckA]

Originally Posted by wrecked_ Don't attatch the .amxx file. EDIT: 1) Fix your indentation, tabs > 4 spaces. 2) Undefine PLUGIN, VERSION, and AUTHOR if you are going to personally fill in the parameters for register_plugin. 3) Edit the whitespace, some is efficient and readable, your is pretty strangely done. ( Just a suggestion, #3 )

1) Fixed.

2) Fixed.

3) Fixed.

4) Reuploaded the files.

[Splat.MothaFuckA]

Wrong button, delete this post.

[wrecked_]

Also, don't post in all bold / large font.

For future reference, when you re-upload a file to a plugin, upload it first and then report the bug fixes.

[Splat.MothaFuckA]

Originally Posted by wrecked_ Also, don't post in all bold / large font. For future reference, when you re-upload a file to a plugin, upload it first and then report the bug fixes.

Thanks for helping me out, new to coding and uploading and shit.. my first plugin xD.

[wrecked_]

Not a problem.

[YamiKaitou]

1) Compile warnings, you need to fix them

Welcome to the AMX Mod X 1.8.1-300 Compiler. Copyright (c) 1997-2006 ITB CompuPhase, AMX Mod X Team C:\Users\YamiKaitou\AppData\Local\Temp\pimpsl ap.sma(21) : warning 217: loose indentation C:\Users\YamiKaitou\AppData\Local\Temp\pimpsl ap.sma(37) : warning 217: loose indentation C:\Users\YamiKaitou\AppData\Local\Temp\pimpsl ap.sma(57) : warning 217: loose indentation C:\Users\YamiKaitou\AppData\Local\Temp\pimpsl ap.sma(60) : warning 217: loose indentation C:\Users\YamiKaitou\AppData\Local\Temp\pimpsl ap.sma(61) : warning 204: symbol is assigned a value that is never used: "dmg" Header size: 324 bytes Code size: 1012 bytes Data size: 1072 bytes Stack/heap size: 16384 bytes; estimated max. usage=779 cells (3116 bytes) Total requirements: 18792 bytes 5 Warnings. Done. C:\Program Files (x86)\Notepad++>

2) Your defines are never used, remove them.

3) Use cmd_access instead of checking the flags manually, you break the cmdaccess.ini usage and you make your code inconsistant.

4) Use tabs OR spaces, not both.

5) Use cmd_target instead of find_player. Doing this allows you to accept a UserID as a parameter in addition to a name.

6) You get a cvar value that doesn't exist and then you never use the returned value

7) You slap a user 99 times and only check the users health before the first slap. What if the user had <98 health when you began slapping?

8) Make your console_print on line 22 more descriptive of what you want the user to provide...

9) There is probably more, but your indentation is crap and annoying :/


EDIT:
10) Don't upload the AMXX file again


EDIT2:
11) Redundant plugin, http://forums.alliedmods.net/showthread.php?p=43199

[Splat.MothaFuckA]

Originally Posted by YamiKaitou 1) Compile warnings, you need to fix them 2) Your defines are never used, remove them. 3) Use cmd_access instead of checking the flags manually, you break the cmdaccess.ini usage and you make your code inconsistant. 4) Use tabs OR spaces, not both. 5) Use cmd_target instead of find_player. Doing this allows you to accept a UserID as a parameter in addition to a name. 6) You get a cvar value that doesn't exist and then you never use the returned value 7) You slap a user 99 times and only check the users health before the first slap. What if the user had <98 health when you began slapping? 8) Make your console_print on line 22 more descriptive of what you want the user to provide... 9) There is probably more, but your indentation is crap and annoying :/ EDIT: 10) Don't upload the AMXX file again EDIT2: 11) Redundant plugin, http://forums.alliedmods.net/showthread.php?p=43199

Errors Fixed, had to have help from a friend, because when I fixed "dmg" I got different errors.

Files Re-Uploaded.

[wrecked_]

PHP Code:

    new health = get_user_health ( id )
    new counter

    if ( health > 1 ) 
    {
        while (counter < 99)
        {
            user_slap ( id, 1)
            counter ++
            console_print(id,"Player has been pimp slapped.")
        }
    } 


--->

PHP Code:

new health = get_user_health( id )
new counter

if( health > 1 )
{
    new slapdmg = health - 1
    
    while( counter < slapdmg )
    {
        user_slap( id, 1 )
        counter++
        console_print( id, "Player has been pimp slapped." )
    }
} 


And - where is the "no fall damage" activated on the player when he's in the air? I don't see anything that would activate it.