[Dragokas]

Originally Posted by Lux ... so querying the client convar c_thirdpersonshoulder only happens once not multiple at once by otherplugins, just by using a simple forward.

That is not correct at all.
Otherplugins, using your plugin's forward, never query for that convar.
And vice versa, your plugin query for that convar multiple times (once each 0.25 sec.).

Also, I noticed several bugs when testing and when observing the source code.
1) I don't see a description of your forward meaning. However "TP_OnThirdPersonChanged" - I think that should mean - call forward only once as soon as person view mode is changed.
However, it is called infinite times for me (see screenshot) - L4d1. Test plugin:

#pragma semicolon 1
#pragma newdecls required

#include <sourcemod>

public void TP_OnThirdPersonChanged(int iClient, bool bIsThirdPerson)
{
	PrintToChat(iClient, "3rd person is changed to: %b", bIsThirdPerson);
}

EDIT. Ok, I found description of forward: "Forwards the varable of c_thirdpersonshoulder client convar".
However, in that case, the name of the forward does not match the meaning. Why not make that forward do exactly how it is named, call the forward only once when person view mode is really changed instead of spamming.

2) You are creating forward call every time QueryClientConVarCallback of "c_thirdpersonshoulder" is raised. It's incorrect. Because if you set third person view, next exit the server, next enter the server again, "c_thirdpersonshoulder" will be initially == 1, but player is in 1st person mode! As soon as I use command "thirdpersonshoulder", "c_thirdpersonshoulder" is changed to "0", but real person view is not changed and at the same time according your logic new forward will be created when it shouldn't. I see you are using some fix, but it is intended for "bIsThirdPerson" value correction only.

[Dragokas]

Originally Posted by Dragokas Because if you set third person view, next exit the server, next enter the server again, "c_thirdpersonshoulder" will be initially == 1, but player is in 1st person mode!

Sorry, I was wrong. Sometimes server put me on 3rd person mode on first join (when c_thirdpersonshoulder == 1).

Thanks for your input i'v improved the plugin and optimized with reducing other plugins receiving forward calls.

Thanks. Anyway, I used your previous code. Very useful.

Do you know, is there netprop I can query for, to check current person view mode? (without using "c_thirdpersonshoulder" ConVar)

[Lux]

if your looking for thirdpersonshoulder in netprops then no there is not, that is clientsided.

It is a combo of netprops e.g. stagger ect.

you can use this bool from LMC
https://github.com/LuxLuma/Luxs-Mode...t.sp#L106-L226

PHP Code:

static bool IsSurvivorThirdPerson(int iClient)
{
    if(bThirdPerson[iClient])
        return true;
    if(GetEntPropEnt(iClient, Prop_Send, "m_hViewEntity") > 0)
        return true;
    if(GetEntPropFloat(iClient, Prop_Send, "m_TimeForceExternalView") > GetGameTime())
        return true;
    if(GetEntProp(iClient, Prop_Send, "m_iObserverMode") == 1)
        return true;
    if(GetEntPropEnt(iClient, Prop_Send, "m_pummelAttacker") > 0)
        return true;
    if(GetEntPropEnt(iClient, Prop_Send, "m_carryAttacker") > 0)
        return true;
    if(GetEntPropEnt(iClient, Prop_Send, "m_pounceAttacker") > 0)
        return true;
    if(GetEntPropEnt(iClient, Prop_Send, "m_jockeyAttacker") > 0)
        return true;
    if(GetEntProp(iClient, Prop_Send, "m_isHangingFromLedge") > 0)
        return true;
    if(GetEntPropEnt(iClient, Prop_Send, "m_reviveTarget") > 0)
        return true;
    if(GetEntPropFloat(iClient, Prop_Send, "m_staggerTimer", 1) > -1.0)
        return true;
    
    switch(GetEntProp(iClient, Prop_Send, "m_iCurrentUseAction"))
    {
        case 1:
        {
            static int iTarget;
            iTarget = GetEntPropEnt(iClient, Prop_Send, "m_useActionTarget");
            
            if(iTarget == GetEntPropEnt(iClient, Prop_Send, "m_useActionOwner"))
                return true;
            else if(iTarget != iClient)
                return true;
        }
        case 4, 5, 6, 7, 8, 9, 10:
        return true;
    }
    
    static char sModel[31];
    GetEntPropString(iClient, Prop_Data, "m_ModelName", sModel, sizeof(sModel));
    
    switch(sModel[29])
    {
        case 'b'://nick
        {
            switch(GetEntProp(iClient, Prop_Send, "m_nSequence"))
            {
                case 626, 625, 624, 623, 622, 621, 661, 662, 664, 665, 666, 667, 668, 670, 671, 672, 673, 674, 620, 680, 616:
                return true;
            }
        }
        case 'd'://rochelle
        {
            switch(GetEntProp(iClient, Prop_Send, "m_nSequence"))
            {
                case 674, 678, 679, 630, 631, 632, 633, 634, 668, 677, 681, 680, 676, 675, 673, 672, 671, 670, 687, 629, 625, 616:
                return true;
            }
        }
        case 'c'://coach
        {
            switch(GetEntProp(iClient, Prop_Send, "m_nSequence"))
            {
                case 656, 622, 623, 624, 625, 626, 663, 662, 661, 660, 659, 658, 657, 654, 653, 652, 651, 621, 620, 669, 615:
                return true;
            }
        }
        case 'h'://ellis
        {
            switch(GetEntProp(iClient, Prop_Send, "m_nSequence"))
            {
                case 625, 675, 626, 627, 628, 629, 630, 631, 678, 677, 676, 575, 674, 673, 672, 671, 670, 669, 668, 667, 666, 665, 684, 621:
                return true;
            }
        }
        case 'v'://bill
        {
            switch(GetEntProp(iClient, Prop_Send, "m_nSequence"))
            {
                case 528, 759, 763, 764, 529, 530, 531, 532, 533, 534, 753, 676, 675, 761, 758, 757, 756, 755, 754, 527, 772, 762, 522:
                return true;
            }
        }
        case 'n'://zoey
        {
            switch(GetEntProp(iClient, Prop_Send, "m_nSequence"))
            {
                case 537, 819, 823, 824, 538, 539, 540, 541, 542, 543, 813, 828, 825, 822, 821, 820, 818, 817, 816, 815, 814, 536, 809, 572:
                return true;
            }
        }
        case 'e'://francis
        {
            switch(GetEntProp(iClient, Prop_Send, "m_nSequence"))
            {
                case 532, 533, 534, 535, 536, 537, 769, 768, 767, 766, 765, 764, 763, 762, 761, 760, 759, 758, 757, 756, 531, 530, 775, 525:
                return true;
            }
        }
        case 'a'://louis
        {
            switch(GetEntProp(iClient, Prop_Send, "m_nSequence"))
            {
                case 529, 530, 531, 532, 533, 534, 766, 765, 764, 763, 762, 761, 760, 759, 758, 757, 756, 755, 754, 753, 527, 772, 528, 522:
                return true;
            }
        }
        case 'w'://adawong
        {
            switch(GetEntProp(iClient, Prop_Send, "m_nSequence"))
            {
                case 674, 678, 679, 630, 631, 632, 633, 634, 668, 677, 681, 680, 676, 675, 673, 672, 671, 670, 687, 629, 625, 616:
                return true;
            }
        }
    }
    return false;
} 


Just remove

PHP Code:

if(bThirdPerson[iClient])
return true; 


That is for the thirdpersonshoulder array.

If you looking for l4d1 i'm not really starting on porting LMC stuff to l4d1 due differences of the netprops.

[Dragokas]

Thanks,
in addition, here are netprops from the basic l4d1 port of ThirdPerson_To_POV by Mr.GameOver:

PHP Code:

static bool:bShouldBePov1(iClient) 
{
    if(GetEntPropEnt(iClient, Prop_Send, "m_pounceAttacker") > 0)
        return true;
    if(GetEntProp(iClient, Prop_Send, "m_isHangingFromTongue") > 0)
        return true; 
    if(GetEntProp(iClient, Prop_Send, "m_tongueOwner") > 0)
        return true;        
    if(GetEntProp(iClient, Prop_Send, "m_reachedTongueOwner") > 0)
        return true; 
    if(GetEntProp(iClient, Prop_Send, "m_isHangingFromLedge") > 0)
        return true;    
    if(GetEntPropEnt(iClient, Prop_Send, "m_reviveTarget") > 0)
        return true; 
    if(GetEntProp(iClient, Prop_Send, "m_healOwner") > 0)
        return true;    
    if(GetEntProp(iClient, Prop_Send, "m_reviveOwner") > 0)  
        return true;    
    if(GetEntProp(iClient, Prop_Send, "m_healTarget") > 0) 
        return true;
    if(GetEntProp(iClient, Prop_Send, "m_isFallingFromLedge") > 0) 
        return true;    
    if(GetEntProp(iClient, Prop_Send, "m_grenadeLayerSequence") > 0) 
        return true;
    if(GetEntProp(iClient, Prop_Send, "m_usingMinigun") > 0) 
        return true;    
     return false;        
} 


[Lux]

Originally Posted by Dragokas Thanks, in addition, here are netprops from the basic l4d1 port of ThirdPerson_To_POV by Mr.GameOver: PHP Code: static bool:bShouldBePov1(iClient)  {     if(GetEntPropEnt(iClient, Prop_Send, "m_pounceAttacker") > 0)         return true;     if(GetEntProp(iClient, Prop_Send, "m_isHangingFromTongue") > 0)         return true;      if(GetEntProp(iClient, Prop_Send, "m_tongueOwner") > 0)         return true;             if(GetEntProp(iClient, Prop_Send, "m_reachedTongueOwner") > 0)         return true;      if(GetEntProp(iClient, Prop_Send, "m_isHangingFromLedge") > 0)         return true;         if(GetEntPropEnt(iClient, Prop_Send, "m_reviveTarget") > 0)         return true;      if(GetEntProp(iClient, Prop_Send, "m_healOwner") > 0)         return true;         if(GetEntProp(iClient, Prop_Send, "m_reviveOwner") > 0)           return true;         if(GetEntProp(iClient, Prop_Send, "m_healTarget") > 0)          return true;     if(GetEntProp(iClient, Prop_Send, "m_isFallingFromLedge") > 0)          return true;         if(GetEntProp(iClient, Prop_Send, "m_grenadeLayerSequence") > 0)          return true;     if(GetEntProp(iClient, Prop_Send, "m_usingMinigun") > 0)          return true;          return false;         }

Thanks ill book mark these for whenever i start porting more modules to l4d1

[Dragokas]

Can you add there, please, RegPluginLibrary() for identification, so other plugins can be hybrid: supports your forward + be a standalone in case this plugin is not installed?
The reason is: not need to query same convar twice (in standalone plugin, when your plugin is pre-installed e.g. together with LMC).
Of course, I could add mandatory requirement: to install your plugin, but you know:
1. People could forget.
2. People could don't like dependencies.
3. It breaks the original structure of initial plugin. I mean, for forks.

[Lux]

Originally Posted by Dragokas Can you add there, please, RegPluginLibrary() for identification, so other plugins can be hybrid: supports your forward + be a standalone in case this plugin is not installed? The reason is: not need to query same convar twice (in standalone plugin, when your plugin is pre-installed e.g. together with LMC). Of course

https://github.com/LuxLuma/-L4D-L4D2...houlder_Detect

Libname "ThirdPersonShoulder_Detect"

Originally Posted by Dragokas 2. People could don't like dependencies.

hand holding will not help, they want it they should install everything required if not good luck.

Originally Posted by Dragokas 3. It breaks the original structure of initial plugin. I mean, for forks.

If the plugin has changed that much it needs a new thread, as let the old thread die.

[axelnieves2012]

Hello, I need help.
Somehow this plugin is spamming my console. But it doesn't seem to spam every client's console.
It just spams host console.
I get this message every 0.1 second:

Cvar query (cookie: 25, status: 0) - name: c_thirdpersonshoulder, value: false

How do I get rid of these annoying messages? I cannot use my console to get any info because this doesn't let me read anything.

[Lux]

Originally Posted by axelnieves2012 Hello, I need help. Somehow this plugin is spamming my console. But it doesn't seem to spam every client's console. It just spams host console. I get this message every 0.1 second: Cvar query (cookie: 25, status: 0) - name: c_thirdpersonshoulder, value: false How do I get rid of these annoying messages? I cannot use my console to get any info because this doesn't let me read anything.

I have nothing much to help you,

Fishy! on SM discord pointed me to

It's prob being called from a mm ext, the arguments matches CEmptyServerPlugin::OnQueryCvarValueFinished

https://github.com/alliedmodders/met....cpp#L277-L283

remove any meta mod plugin that does not come with source mod

Unless there is some logging level you have toggled i'm not sure.

[axelnieves2012]

Originally Posted by Lux I have nothing much to help you, Fishy! on SM discord pointed me to https://github.com/alliedmodders/met....cpp#L277-L283 remove any meta mod plugin that does not come with source mod Unless there is some logging level you have toggled i'm not sure.

Thanks, I will keep trying. It was useful. Non SM extension I've installed are Left4deadToolz (to let my server have more than 8 players) and Left4Downtown.
I'm not sure if I enabled any logging. Thanks.