[minimiller]

so ive got this code

PHP Code:

public cmdTeleTeam(id)
{
    if(is_user_alive(id))
    {
        new iPlayers[32], iTotal;
        new CsTeams:iTeam = cs_get_user_team(id);
        
        if(iTeam == CS_TEAM_CT)
            get_players(iPlayers, iTotal, "e", "TERRORIST");
        else if(iTeam == CS_TEAM_T)
            get_players(iPlayers, iTotal, "e", "CT");
        else
            return PLUGIN_CONTINUE;
        
        client_print(0, print_chat, "playersnum: %i", get_playersnum());
        client_print(0, print_chat, "iTotal: %i", iTotal);
        
        for(new i; i<iTotal; i++)
        {
            if(is_user_alive(iPlayers[i]))
            {
                new Float:flOrigin[3];
                
                pev(iPlayers[i], pev_origin, flOrigin);
                flOrigin[2] += 73.0;
                set_pev(id, pev_origin, flOrigin);
                client_print(id, print_console, "Teleported Above An Enemy");
                
                return PLUGIN_CONTINUE;
            }
        }
        
        client_print(id, print_console, "There Are No Enemies!");
    }
    
    return PLUGIN_HANDLED;
} 


but its not working
yes, i know the funcwiki says that "Note: "e" flag can return incorrect results (for cstrike/czero at least)."
Ive figured out that if im a CT trying to tele above a Ts head, it dosent work but if im a T trying to teleport above a CTs head, it does work


Is there something wrong with my code? or is it just that the "incorrect results" have come along to destory my day?

if its the latter, what other code can i use to get the same effect?
im guessing looping through to get_maxplayers() and checking cs_get_user_team(i)

posting here is my last resort btw
ive done so many tests on so many different maps using bots bots and players, but it only ever worked for Ts teleporting onto CTs =[

[Bugsy]

ive had inconsistent results with getplayers too. the same exact code one day returned correct and valid players other days it returned no players when it should have returned some.i recommend checking manually

[01101101]

Originally Posted by BAILOPAN We don't really support get_players() with flags anymore. It was a bad idea and if it was our choice, it would have never been added to the original AMX Mod.

And, if you see at the func list it says

Originally Posted by http://www.amxmodx.org/funcwiki.php?go=func&id=174 Note: "e" flag can return incorrect results (for cstrike/czero at least).

[Bugsy]

Originally Posted by 01101101 And, if you see at the func list it says

he did note that he saw that in the funcwiki

[ConnorMcLeod]

Try to also use flag "a" since it seems you only need to retrieve alive players.
If it still returns false results (i thought i could return false results for dead players only), do manually a loop.
Also, don't forget to check the hull before you teleport yourself, and don't forget that set_pev is not the correct way to teleport, see engine set_entity_origin source code :

static cell AMX_NATIVE_CALL entity_set_origin(AMX *amx, cell *params)
{
	int iEnt = params[1];

	CHECK_ENTITY_SIMPLE(iEnt);
	
	edict_t *pEnt = INDEXENT2(iEnt);
	cell *vVector = MF_GetAmxAddr(amx, params[2]);
	REAL fX = amx_ctof(vVector[0]);
	REAL fY = amx_ctof(vVector[1]);
	REAL fZ = amx_ctof(vVector[2]);
	Vector vOrigin = Vector(fX, fY, fZ);

	SET_SIZE(pEnt, pEnt->v.mins, pEnt->v.maxs);
	SET_ORIGIN(pEnt, vOrigin);

	return 1;
}

SET_SIZE would be EngFunc_SetSize or entity_set_size, and SET_ORIGIN would be EngFunc_SetOrigin.

I would try something like this :

PHP Code:

new const Float:VEC_DUCK_HULL_MIN[3]    = {-16.0, -16.0, -18.0 }
new const Float:VEC_DUCK_HULL_MAX[3]    = { 16.0,  16.0,  32.0 }
new const Float:VEC_DUCK_VIEW[3]        = {  0.0,   0.0,  12.0 }

public cmdTeleTeam(id)
{
    if(is_user_alive(id))
    {
        new iPlayers[32], iTotal, plr
        get_players(iPlayers, iTotal, "ae", cs_get_user_team(id) == CS_TEAM_CT ? "TERRORIST" : "CT")

        new Float:fVecOrigin[3], Float:fVecMaxs[3]
        for(new i; i<iTotal; i++)
        {
            plr = iPlayers[i]
            pev(plr, pev_origin, fVecOrigin)
            pev(plr, pev_maxs, fVecMaxs)
            fVecOrigin[2] += ( fVecMaxs[2] + VEC_DUCK_HULL_MIN[2] + 1.0 /* + 2.0 ? */)
            if( trace_hull(fVecOrigin, HULL_POINT, plr /* 0 ? */, DONT_IGNORE_MONSTERS) == 0 )
            {
                Util_SetOrigin(id, fVecOrigin)
                client_print(id, print_console, "Teleported Above An Enemy")
                break
            }
        }

        client_print(id, print_console, "There Are Avaible Place Above Enemies!")
    }

    return PLUGIN_HANDLED
}

Util_SetOrigin(const id, const Float:fVecOrigin[3])
{    
    entity_set_int(id, EV_INT_flags, entity_get_int(id, EV_INT_flags) | FL_DUCKING)
    engfunc(EngFunc_SetSize, id, VEC_DUCK_HULL_MIN, VEC_DUCK_HULL_MAX)
    engfunc(EngFunc_SetOrigin, id, fVecOrigin)
    entity_set_vector(id, EV_VEC_view_ofs, VEC_DUCK_VIEW)
} 


If it works, could be a good solution for campers, open a menu to ennemy like "NAME is camping, do you want to be teleported above his head ?"

[minimiller]

Ok thx for the help guys

@Connor: Im guessing that checks if either of the players are ducked before teleporting them (i couldnt really read it on my phone =[)

Would it be better if i looped through to get_maxplayers() and left out get_players() alltogether? or should i use get_players(iPlayers, iTotal, "ah") then in the loop to iTotal check cs_get_user_team(iPlayers[i])?

PHP Code:

new iPlayers[32], iTotal, CsTeams:iTeam = cs_get_user_team(id);
get_players(iPlayers, iTotal, "ah"); 

for(new i; i<iTotal; i++)
{
    if(cs_get_user_team(iPlayers[i]) != iTeam)
    {
        //Do stuff
    }
} 


Also: Does ne1 know why they dropped support for get_players()? its such a handy tool =]

[ConnorMcLeod]

No, the check is if the target player is ducked, so you retrieve a more accurate above origin, then you check the hull of a ducked player and you teleport yourself as if you were ducked.
I've never had any problem with flag "e" combinated with fag "a".

[minimiller]

ahh i c
ill test that on 2moro after work
thx again

[ConnorMcLeod]

I thinks it's because get_user_team is updated when ScoreInfo message is sent, and when a player is dead that message is not sent (sometimes ?).
Not sure though.

Anyway, have you tested the code i gave you ?

[minimiller]

not yet
i havent been @ my PC since i posted this thread