[Krystek.]

Originally Posted by fysiks Did you remove both of them? It also looks like you haven't fixed the amx_log arguments that I mentioned. I think that will probably cause an error and prevent the loop from working like it should.

Forgive the confusion, edited my previous post, would you please take another look?

[fysiks]

Ok, so I think I misunderstood what the original code was doing so my suggestions won't work correctly. If the original code was working, I'd simply go with that.

If the original code wasn't working then you'll need to explain, with words, how you're wanting this function/code to behave.

[Krystek.]

Originally Posted by fysiks Ok, so I think I misunderstood what the original code was doing so my suggestions won't work correctly. If the original code was working, I'd simply go with that. If the original code wasn't working then you'll need to explain, with words, how you're wanting this function/code to behave.

PHP Code:

    if(cod_get_user_perk(vid) == 1 || cod_get_user_perk(vid) == 2 || cod_get_user_perk(vid) == 3 || cod_get_user_perk(vid) == 4 || cod_get_user_perk(vid) == 7 || cod_get_user_perk(vid) == 13) {
        durability_perks[vid] -= (durability_perks[vid] > damage_better_items)? damage_better_items: durability_perks[vid];
    } else {
        durability_perks[vid] -= (durability_perks[vid] > damage_items)? damage_items: durability_perks[vid];
    } 


It's supposed to work the same as above but with the code changed to this one.

PHP Code:

    new const perks_id[] = { 1, 2, 3, 4, 7, 13 };
    new perk_player = cod_get_user_perk(id);

    for( new i = 0; i < sizeof(perks_id); ++i ) {
        if( perk_player == perks_id[i] ) {
            log_amx("Better Durability: %i | PerkID %i", durability_perks[id], perks_id[i]);
            durability_perks[id] -= (durability_perks[id] > damage_better_items)? damage_better_items: durability_perks[id];
            log_amx("Better Durability: %i | PerkID %i", durability_perks[id], perks_id[i]);
        } else {
            log_amx("Durability: %i", durability_perks[id], perks_id[i]);
            durability_perks[id] -= (durability_perks[id] > damage_items)? damage_items: durability_perks[id];
            log_amx("Durability: %i", durability_perks[id], perks_id[i]);
        }
    } 


[fysiks]

Right, so the only thing your changing is the dynamic search of the perks_id array. I've been analyzing it for a since my last post and I came up with this:

PHP Code:

    new damage_better_items = random_num(3, 12);
    new damage_items         = random_num(1, 6);

    new perks_id[] = { 1, 2, 3, 4, 7, 13 };

    new bool:bFound = false;
    for( new i; i < sizeof(perks_id); i++ )
    {
        if( cod_get_user_perk(vid) == perks_id[i] )
        {
            bFound = true;
            break;
        }
    }

    durability_perks[vid] = max(0, durability_perks[vid] - (bFound ? damage_better_items : damage_items)) // The max() simply enforces a minimum of 0