[ot_207]

Originally Posted by joaquimandrade But it hooks spawn and it uses task. As i said in there is better. I never need to mess with models but, if someday i do, i will surely modify his code. Basically: It hooks spawns. That's an error. Then it uses tasks to protect problems coming from changing the models in spawn. Hooking instead the join team event you will not need task. You won't have 32 players changing the team at the same time.

I know, you don't need to explain, this is your situation or any other good coders situation. There are some problems that will be fixed on that tutorial. If a scripter needs it he will modify the code. It depends on experience at first, if a scripter is a beginner he can't be able to see all weak spots of a code. That is a thing which everyone will learn with time.

[joaquimandrade]

Originally Posted by ot_207 I know, you don't need to explain, this is your situation or any other good coders situation. There are some problems that will be fixed on that tutorial. If a scripter needs it he will modify the code. It depends on experience at first, if a scripter is a beginner he can't be able to see all weak spots of a code. That is a thing which everyone will learn with time.

The thing is: despite the fact that his code make things better it also does things wrong. It is re-setting models on spawn so, in a 32 slots full server, when a round begins it is re-setting 32 models (despite the fact that it is not needed). And because of that it also has tasks to prevent problems that can arise from these simultaneous re-sets. So, it's not only the efficient that it can be as it also can still let problems happen. By hooking team join event you would never re-set 32 models at the same time.

So basically what am i saying?
Changing its code like i said is not a trivial optimization but, for me, a obligatory one.