[lobnico]

When changing damage value inside hook function,
if attack is a crit it will negate value,
giving infinite overheal instead of damaging.

PHP Code:


public Action:OnTakeDamageAlive(victim, &attacker, &inflictor, &Float:damage, int &damagetype, int &weapon,
        float damageForce[3], float damagePosition[3], int damagecustom)
{

    damage = 1.0 //any change to damage will work unless its a crit

    return Plugin_Changed;
} 


Bug occurs wheter it's OnTakeDamage Pre/Post, OnTakeDamageAlive Pre/Post.

[Benoist3012]

I'm getting some reports on SF2 where apparently some players get infinite overheal, so I'm interested to know if it's this function causing it.

[lobnico]

Originally Posted by Benoist3012 I'm getting some reports on SF2 where apparently some players get infinite overheal, so I'm interested to know if it's this function causing it.

Sounds like it. Any modification of damage during hook cause that bug if dmg is crit

Temporary fix is to move dmg modification on Player_Hurt event and use
SetEntProp to apply victim new health; works swell, prevent death too !

PHP Code:


public Action:Event_PlayerDmg(Event event,const String:name[],bool:dontBroadcast){

    int victim = GetClientOfUserId(event.GetInt("userid"));
    int dmg = event.GetInt("damageamount");
    int healthModifier
    //... modify dmg here and get health difference

    //reset proper display value for attacker
    event.SetInt("damageamount", dmg); 
    //reset proper health value remainin for victim
    SetEntProp(
       victim,
       Prop_Send,
       "m_iHealth", 
       GetEntProp(victim, Prop_Send, "m_iHealth") + healthModifier) 
    return Plugin_Changed;
}