[Strick3n]

public selectSub( client, menu, item )
{
	switch( item )
	{
		case 0: 
			showBanMenu( client );
		case 1: 
			showRemoveMenu( client );
	}
	
	if( item == 2 )
	{
		new arrSize = ArraySize( g_aBannedList );
		
		if( arrSize )
		{
			for( new i = 0; i < arrSize; i++ )
			{
				ArrayDeleteItem( g_aBannedList, i );
			}
			
			SaveBannedToFile( g_aBannedList, g_szBannedList );
			
			menu_cancel( client );
			show_menu( client, 0, "^n", 1 );
			
			client_print( 0, print_chat, "[%s] All banned players has been removed from the banned file!", PLUGIN_NAME );
			
			showSelectMenu( client );
		}
		
		else
		{
			client_print( client, print_chat, "[%s] Banned file is empty!", PLUGIN_NAME );
			
			showSelectMenu( client );
			
			return 1;
		}
		
		return 1;
	}
	
	return 1;
}

i keep getting this message when i'm trying to delete all array items

L 11/14/2023 - 19:59:06: Invalid item specified in ArrayDeleteItem (6:6)
L 11/14/2023 - 19:59:06: [AMXX] Displaying debug trace (plugin "AdvancedBans.amxx")
L 11/14/2023 - 19:59:06: [AMXX] Run time error 10: native error (native "ArrayDeleteItem")
L 11/14/2023 - 19:59:06: [AMXX]    [0] AdvancedBans.sma::selectSub (line 133)

please help me

[Jhob94]

ArrayDeleteItem had some bug several years ago. I have no idea if the dev team corrected it. Try to search more about the error.

[xDrugz]

Originally Posted by Jhob94 ArrayDeleteItem had some bug several years ago. I have no idea if the dev team corrected it. Try to search more about the error.

so you suggest him to use trie instead?

[Strick3n]

i managed to solve the problem by using ArrayClear

[Jhob94]

Originally Posted by Strick3n i managed to solve the problem by using ArrayClear

That’s for the best but now i wonder if the arraydeleteitem is still bugged

Edit:
What amxx version are you using?

[Leech_v2]

Try not to use forward traversal to delete array elements as much as possible. After element 1 is deleted, element 2 will become element 1, and array size 3 will become 2. At this point, deleting element 2 will trigger an "index out of bounds".
The solution is to use reverse traversal, or reduce the loop every time an element is deleted

PHP Code:

// Optimal solution
ArrayClear(arrayHandle);

// reverse traversal
for (new elementId = ArraySize(arrayHandle); elementId--;)
{
    ArrayDeleteItem(arrayHandle, elementId);
}

// forward traversal
for (new numElements = ArraySize(arrayHandle); numElements; numElements--)
{
    ArrayDeleteItem(arrayHandle, 0);
}

// forward traversal (Poor quality code)
for (new numElements = ArraySize(arrayHandle), elementId; elementId < numElements; elementId++)
{
    ArrayDeleteItem(arrayHandle, elementId);
    elementId--;
    numElements--;
} 


[Strick3n]

Originally Posted by Jhob94 That’s for the best but now i wonder if the arraydeleteitem is still bugged Edit: What amxx version are you using?

1.8.2 as far as i know